Updates to course treatment interval, reproductive status (multiple foetus, do not breed event) #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cookeac
commented
Jul 29, 2021
cookeac
commented
- Correct treatmentInterval to an integer (not a double, as it is in hours already)
- Add PregnantMultipleFoetus to icarAnimalReproductiveStatus - resolves Add "PregnantMultipleFoetus" in the icarAnimalReproductionStatusType #223
- Add boolean flag to icarReproDoNotBreedEventResource - resolves Remove DoNotBreed from animal #213
Correct *treatmentInterval* in **icarMedicineCourseSummaryType.json** to an integer per [comment in 227](adewg#227 (comment))
Added "PregnantMultipleFoetus" to **icarAnimalReproductionStatusType**. Use this to indicate that an animal has been confirmed to be carrying multiple foetuses. Fixes adewg#223
Added a boolean, nullable (default true) *doNotBreed* to document toggling the reproductive status "Do Not Breed" on or off. Fixes adewg#213
This was
linked to
issues
Jul 29, 2021
|
Hey Andrew, the latest change (removing the format=double) looks fine to me :) However, it seems that there's multiple tickets in this pull request and now it conflicts with the other changes. I'll try and resolve it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.